RFR: 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out [v3]

Kevin Walls kevinw at openjdk.org
Mon Jul 22 15:13:08 UTC 2024


> Short version:
> Stop testing this test with -Xcomp by adding requires vm.compMode != "Xcomp"
> 
> Make additional typo fixes and tidyups while here, it's just shocking.
> 
> TestDescription.java contains the test definition, so the "requires" goes there, with a comment.
> 
> Updates to from001.java are typos and clarifications, and a changed loop with a poll on a queue rather than block forever.

Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8332551_MemoryNotificationInfo_from001
 - formatting
 - update
 - 8332551: Test vmTestbase/nsk/monitoring/MemoryNotificationInfo/from/from001/TestDescription.java timed out

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/20146/files
  - new: https://git.openjdk.org/jdk/pull/20146/files/a6965231..bcf6b450

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=20146&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=20146&range=01-02

  Stats: 8630 lines in 367 files changed: 5704 ins; 1620 del; 1306 mod
  Patch: https://git.openjdk.org/jdk/pull/20146.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/20146/head:pull/20146

PR: https://git.openjdk.org/jdk/pull/20146


More information about the serviceability-dev mailing list