RFR: 8327054: DiagnosticCommand Compiler.perfmap does not log on output() [v4]

Kevin Walls kevinw at openjdk.org
Tue Jul 23 08:03:38 UTC 2024


On Mon, 22 Jul 2024 15:36:47 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This is a small patch to address [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making `CodeCache::write_perf_map` aware of which output stream errors and warning message should be going to.
>> 
>> Testing: 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updating warning message

Marked as reviewed by kevinw (Reviewer).

Yes looks good. I only waited in case you were changing "outputStream* st" to be called out or output, to address Thomas' comment.  (I notice now the added comment.)

-------------

PR Review: https://git.openjdk.org/jdk/pull/20257#pullrequestreview-2193261838
PR Comment: https://git.openjdk.org/jdk/pull/20257#issuecomment-2244523438


More information about the serviceability-dev mailing list