RFR: 8334492: DiagnosticCommands (jcmd) should accept %p in output filenames and substitute PID [v9]

[Sonia Zaldana Calles]

On Wed, 24 Jul 2024 10:35:35 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge master
>>  - Fixing formatting
>>  - Inlining buffer and making field private
>>  - Reverting to functional changes in parserTests.cpp
>>  - Error messaging format
>>  - Fixing memory leak
>>  - Fixing pointer style, s/NULL/nullptr, and exception
>>  - Cleaning up parserTests.cpp
>>  - Missing copyright header update
>>  - Adding tests for file dcmd argument
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/2f2223d7...52ca557d
>
> src/hotspot/share/services/diagnosticArgument.hpp line 65:
> 
>> 63: class FileArgument {
>> 64:   private:
>> 65:     char _name[1024];
> 
> Probably JVM_MAXPATHLEN (which might also be 1024).

Hi, I avoided JVM_MAXPATHLEN because of this comment https://github.com/openjdk/jdk/pull/20198#discussion_r1685297940

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20198#discussion_r1690215958