RFR: 8330427: Obsolete -XX:+PreserveAllAnnotations [v2]

[Alex Menkov]

On Thu, 25 Jul 2024 01:17:14 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove test
>
> test/jdk/java/lang/instrument/RetransformRecordAnnotation.java line 32:
> 
>> 30:  * @run shell MakeJAR.sh retransformAgent
>> 31:  * @run main/othervm -javaagent:retransformAgent.jar -Xlog:redefine+class=trace RetransformRecordAnnotation
>> 32:  * @run main/othervm -javaagent:retransformAgent.jar -XX:+PreserveAllAnnotations -Xlog:redefine+class=trace RetransformRecordAnnotation
> 
> This test is described as:
> 
>  * @summary test that records with invisible annotation can be retransformed
>  ```
> which suggests to me the test can actually be deleted as it serves no purpose now there are no invisible annotations

Agree.
Removed the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20315#discussion_r1690681450