RFR: 8335701: Make GrowableArray templated by an Index [v3]

Johan Sjölen jsjolen at openjdk.org
Fri Jul 26 12:46:48 UTC 2024


On Fri, 5 Jul 2024 07:38:12 GMT, Glavo <duke at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Fix
>>  - Apparently this(!)
>>  - This?
>>  - Use COMMA
>
> src/hotspot/share/classfile/classFileParser.hpp line 46:
> 
>> 44: class ConstMethod;
>> 45: class FieldInfo;
>> 46: template<typename E, typename Index>
> 
> Suggestion:
> 
> template<typename E, typename Index = int>
> 
> 
> Is it possible to reduce the changes by providing default parameters?

Unfortunately, no. Forward decl.s may not re-define the default template argument, even though they are the same as the definition.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20031#discussion_r1666460897


More information about the serviceability-dev mailing list