RFR: 8337031: Improvements to CompilationMemoryStatistic [v2]

Ashutosh Mehra asmehra at openjdk.org
Mon Jul 29 16:05:33 UTC 2024


On Sat, 27 Jul 2024 05:44:14 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> What do you mean by x macro? Do you have an example that shows the use of x macro?
>
> You use them already in your patch.
> 
> E.g. 
> 
> 
> #define XX(name, whatever, desc) st->print_cr("  " LEGEND_KEY_FMT ": " #name #desc
> DO_ARENA_TAG(XX)
> #undef XX
> 
> 
> Admittedly, it is not a lot less code than the for loop. Up to you.

I will keep the loop if you don't have strong preference for the macro usage here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20304#discussion_r1695486252


More information about the serviceability-dev mailing list