RFR: 8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected

[Serguei Spitsyn]

On Sat, 27 Jul 2024 01:55:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> The test is setting breakpoints on the wrong line numbers, which causes setting up the breakpoint to fail, but the test also has buggy error checking, so the test doesn't detect the failures and still passes. I fixed the breakpoint line numbers and the error checking. More details in the first comment.
> 
> Testing tbd: I'll run the tier5 svc testing, which includes this test suite.

This looks good. I've posted one question.

test/hotspot/jtreg/vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java line 147:

> 145:         }
> 146: 
> 147:         found = grep.findFirst("Breakpoint hit: \"thread=main\", ");

Q: Is it possible to check for the exact breakpoint location here?

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20366#pullrequestreview-2209432354
PR Review Comment: https://git.openjdk.org/jdk/pull/20366#discussion_r1698063176