RFR: 8311990: Two JDI tests may interfere with each other [v2]

Alex Menkov amenkov at openjdk.org
Wed Jul 31 19:58:31 UTC 2024


On Wed, 31 Jul 2024 12:08:33 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add sys.prop to enable negative testing
>
> test/jdk/com/sun/jdi/JdwpListenTest.java line 54:
> 
>> 52:     // It's off by default as it causes test time increase and test interference (see JDK-8231915).
>> 53:     private static boolean allowNegativeTesting =
>> 54:         "true".equalsIgnoreCase(System.getProperty("JDI_ALLOW_NEGATIVE_TESTING"));
> 
> That seems a strange name for a system property - it would normally be something like jdk.jdi.allowNegativeTesting. Is this style of naming being used elsewhere?

Renamed as suggested.
IIRC we had `-Duse.JTREG_TEST_THREAD_FACTORY=Virtual` some time ago. Other tests use "standard" naming

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20362#discussion_r1699033342


More information about the serviceability-dev mailing list