RFR: 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container) [v3]

Mon Jun 3 20:50:32 UTC 2024

On Tue, 21 May 2024 17:10:15 GMT, Sebastian Lövdahl <duke at openjdk.org> wrote:

>> 8327114: Attach in Linux may have wrong behaviour when pid == ns_pid (Kubernetes debug container)
>
> Sebastian Lövdahl has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove unused `SELF_PID_NS`
>  - Rewrite in line with suggestion from Larry Cable

going to take a look at a couple of the "containers" tests to see if I 
can "quickly" clone them to provide a bootstrap for this patch...

- Larry

On 6/3/24 10:24 AM, Sebastian Lövdahl wrote:
>
> Hi Larry, no worries. :)
>
> I can try to look into writing some tests for the elevated use-cases. 
> but it will be quite much treading of new ground for me, so it could 
> take some time to get it done.
>
> What's your take, do we need the new tests in this PR, or could it be 
> done in a follow-up?
>
> —
> Reply to this email directly, view it on GitHub 
> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2ou5TXc0g$>, 
> or unsubscribe 
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67SLY6ZRE5DP7RNIRR3ZFSREFAVCNFSM6AAAAABHDNNTT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG42DSNZXGM__;!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2pvqMZDog$>.
> You are receiving this because you were mentioned.Message ID: 
> ***@***.***>
>

--------------XIGzXIQgYm0WtZy9a5FZZTYy
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    going to take a look at a couple of the "containers" tests to see if
    I can "quickly" clone them to provide a bootstrap for this patch...<br>
    <br>
    - Larry<br>
    <br>
    <div class="moz-cite-prefix">On 6/3/24 10:24 AM, Sebastian Lövdahl
      wrote:<br>
    </div>
    <blockquote type="cite" ***@***.***">
      <p dir="auto">Hi Larry, no worries. :)</p>
      <p dir="auto">I can try to look into writing some tests for the
        elevated use-cases. but it will be quite much treading of new
        ground for me, so it could take some time to get it done.</p>
      <p dir="auto">What's your take, do we need the new tests in this
        PR, or could it be done in a follow-up?</p>
      <p>—<br>
        Reply to this email directly, <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19055*issuecomment-2145749773__;Iw!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2ou5TXc0g$" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67SLY6ZRE5DP7RNIRR3ZFSREFAVCNFSM6AAAAABHDNNTT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVG42DSNZXGM__;!!ACWV5N9M2RV99hQ!K0MEZ8qTAcfQbuAvzL9Owp185kbnkkocR0vuh5wia4Zlg3fFzKwJo5WgGVBMUSe_N5Hef4teGHbUKcyPg2pvqMZDog$" moz-do-not-send="true">unsubscribe</a>.<br>
        You are receiving this because you were mentioned.<img alt="" moz-do-not-send="true" width="1" height="1"><span>Message ID:
          <span><openjdk/jdk/pull/19055/c2145749773</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
    </blockquote>
    <br>
  </body>
</html>

--------------XIGzXIQgYm0WtZy9a5FZZTYy--

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19055#issuecomment-2146095382