RFR: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers [v5]
Chris Plummer
cjplummer at openjdk.org
Mon Jun 3 22:05:52 UTC 2024
On Mon, 3 Jun 2024 09:58:38 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> The following RFE was fixed recently:
>> [8324680](https://bugs.openjdk.org/browse/JDK-8324680): Replace NULL with nullptr in JVMTI generated code
>>
>> It replaced all the `NULL`'s in the generated spec with`nullptr`. JVMTI agents can be developed in C or C++.
>> This update is to make it clear that `nullptr` is C programming language `null` pointer.
>>
>> I think we do not need a CSR for this fix.
>>
>> Testing: N/A (not needed)
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: consistency and stylistical corrections
src/hotspot/share/prims/jvmti.xml line 1007:
> 1005: explicitly deallocate. This is indicated in the individual <jvmti/>
> 1006: function descriptions. Empty lists, arrays, sequences, etc are
> 1007: returned as a null pointer (C <code>NULL</code> or C++ <code>nullptr</code>).
Why describe what is meant by a "null pointer" here when it is not done elsewhere?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19257#discussion_r1625105918
More information about the serviceability-dev
mailing list