RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v7]

[Inigo Mediavilla Saiz]

On Tue, 4 Jun 2024 05:33:47 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Print mounted virtual thread after carrier
>
> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
> 
> New file should only have current year in copyright notice.

Thanks, I've updated it.

> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: import com.beust.ah.A;
> 
> ???

Wait, I don't know where that's coming from. I've removed it as well as the other imports that are not being used.

> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java line 37:
> 
>> 35: import java.util.concurrent.atomic.AtomicBoolean;
>> 36: import java.util.concurrent.locks.ReentrantLock;
>> 37: import java.util.regex.Pattern;
> 
> Seems to be a number of unneeded imports here.

Thanks, I've removed them here: b122cc05ff953a890e4f604d37785f06e13e2ff6

> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java line 46:
> 
>> 44:  *          java.compiler
>> 45:  *          java.management
>> 46:  *          jdk.internal.jvmstat/sun.jvmstat.monitor
> 
> These don't all seem necessary.

Thanks, I've removed them.

> test/hotspot/jtreg/serviceability/dcmd/thread/PrintVirtualThreadTest.java line 52:
> 
>> 50: 
>> 51:     public void run(CommandExecutor executor) throws InterruptedException {
>> 52:         var shouldStop = new AtomicBoolean();
> 
> You never set this to stop the thread.

I've fixed it in: b122cc05ff953a890e4f604d37785f06e13e2ff6

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625478440
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625478212
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625481515
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625481097
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1625481256