RFR: 8333130: MakeJAR2.sh uses hard-coded JDK version [v4]

Jaikiran Pai jpai at openjdk.org
Tue Jun 4 08:50:18 UTC 2024


On Tue, 4 Jun 2024 07:13:39 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Alex suggestion - remove -XX:-CheckIntrinsics from NativeMethodPrefixApp test too
>>  - Alex's suggestion - no need to include only the bootreporter classes in boot classpath
>>  - RetransformApp test did not previously use -XX:-CheckIntrinsics
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.java line 26:
> 
>> 24: 
>> 25: import java.io.File;
>> 26: import java.nio.file.Files;
> 
> Nit: It seems the import at line 26 is not needed.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1625617051


More information about the serviceability-dev mailing list