RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v8]
Inigo Mediavilla Saiz
duke at openjdk.org
Tue Jun 4 13:50:47 UTC 2024
On Tue, 4 Jun 2024 08:51:40 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Inigo Mediavilla Saiz has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Cleanup test
>>
>> - Stop virtualthread
>> - Remove unneeded imports
>> - Remove modules that are not needed
>> - Fix copyright year
>
> src/hotspot/share/runtime/threads.cpp line 1336:
>
>> 1334: oop vt = p->vthread();
>> 1335: assert(vt != nullptr, "");
>> 1336: st->print_cr(" \tMounted virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt));
>
> Please no manual indentation, see remarks above.
I'm leaving minimal indentation and I will update the code on a new PR to rely on your changes if it's OK for you @tstuefe
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1626049632
More information about the serviceability-dev
mailing list