RFR: 8332070: Convert package.html files in `java.management` to package-info.java [v2]
Alan Bateman
alanb at openjdk.org
Tue Jun 4 19:27:58 UTC 2024
On Mon, 27 May 2024 09:01:48 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> This is a simple noreg cleanup. The motivation was that I noticed javac doesn't recognise package.html files well.
>>
>> Some of the contents of the `package.html` files (and code in the package) may be outdated, but I think it is out of scope for this PR.
>>
>> I have also changed three `{@link }` usages with the `href` that would have been in the generated HTML.
>> Because referencing an element from an other module wouldn't work even when using the `module/package.class#member`, if the `module-info.java` file does not have "require `<name>`".
>>
>> I am referring to line 69 in
>> `src/java.management/share/classes/javax/management/monitor/package-info.java`
>> and lines 90 and 120 in
>> `src/java.management/share/classes/javax/management/remote/package-info.java`
>>
>> Adding 2 dependencies just for 3 links didn't seem right.
>>
>> edit: passes all tests, the failing test is a github actions issue
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> better indentation - no content changes
Looks okay, just notice that classes/java/lang/management/package-info.java still has the double space. Not a big deal but since you fixed the others then maybe do this one too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19399#issuecomment-2148243229
More information about the serviceability-dev
mailing list