RFR: 8333566: Remove unused methods

[Vladimir Kozlov]

On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

> Please, consider this patch to remove unused methods from the code base. To the best of my knowledge, these methods are only defined but never used.
> 
> Here is a list with names of delete methods: https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874
> 
> Tested with Linux x86_64 tier1-4, GHA, and only cross building to other platforms.

src/hotspot/cpu/x86/macroAssembler_x86.hpp line 992:

> 990:   // * No condition for this *  void ALWAYSINLINE jecxz(Label& L, bool maybe_short = true) { jcc(Assembler::cxz, L, maybe_short); }
> 991: 
> 992:   // Short versions of the above

These all branch instructions were added recently [#18893](https://github.com/openjdk/jdk/pull/18893) for JDK-8320448 which is not pushed yet. So I will suggest to not remove them.

src/hotspot/cpu/x86/vm_version_x86.hpp line 666:

> 664:   // Feature identification which can be affected by VM settings
> 665:   //
> 666:   static bool supports_cpuid()        { return _features  != 0; }

I suggest to not touch this file. Some CPU features could used in a future.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19550#discussion_r1630110159
PR Review Comment: https://git.openjdk.org/jdk/pull/19550#discussion_r1630112304