RFR: 8333130: MakeJAR2.sh uses hard-coded JDK version [v3]

[Jaikiran Pai]

On Tue, 4 Jun 2024 01:30:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> test/jdk/java/lang/instrument/RetransformApp.java line 81:
>> 
>>> 79:         final OutputAnalyzer oa = ProcessTools.executeTestJava(
>>> 80:                 "--enable-preview", // due to usage of ClassFile API PreviewFeature in the agent
>>> 81:                 "-XX:+UnlockDiagnosticVMOptions", "-XX:-CheckIntrinsics",
>> 
>> This `-XX` flags were not present for this test (and I don't think they are needed for NativeMethodPrefix test too)
>
> You are right - it was  a copy/paste error on my part to have include these flags for the `RetransformApp`.  Based on your suggestion, I have removed them from the other test too. The tests continue to pass.

It turns out we do need the `-XX:-CheckIntrinsics` for the `NativeMethodPrefix` test. Without that we have a test failure in a higher tier https://bugs.openjdk.org/browse/JDK-8333756.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19495#discussion_r1630482492