RFR: 8322811: jcmd System.dump_map help info has conflicting statements

Kevin Walls kevinw at openjdk.org
Mon Jun 10 08:38:11 UTC 2024


On Fri, 7 Jun 2024 10:40:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> @dholmes-ora this is one of yours.
> 
> This was a tad annoying to fix (fix is simple though), since the jcmd framework has no good way to allow for default parameters that are not used literally. E.g. in this case, the real value for the file name will contain the process pid, which of course cannot be hard-coded.
> 
> New output:
> 
> 
> Syntax : System.dump_map [options]
> 
> Options: (options must be specified using the <key> or <key>=<value> syntax)
>         -H : [optional] Human readable format (BOOLEAN, false)
>         -F : [optional] file path (STRING, vm_memory_map_<pid>.txt)

Looks good to me, yes non-literal defaults are a bit awkward here.

-------------

Marked as reviewed by kevinw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19596#pullrequestreview-2107075791


More information about the serviceability-dev mailing list