RFR: 8333756: java/lang/instrument/NativeMethodPrefixApp.java failed due to missing intrinsic [v2]

Jaikiran Pai jpai at openjdk.org
Tue Jun 11 02:10:47 UTC 2024


On Mon, 10 Jun 2024 19:05:36 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update code comment
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.java line 103:
> 
>> 101:                 // the native method names, which then causes a failure in the VM check
>> 102:                 // for the presence of an intrinsic on a @IntrinsicCandidate native method
>> 103:                 "-XX:+UnlockDiagnosticVMOptions", "-XX:-CheckIntrinsics",
> 
> Can you update both comments to begin with a capital letter and end with a period. Thanks.

Done, I've updated the PR with this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19595#discussion_r1634061698


More information about the serviceability-dev mailing list