RFR: 8330534: Update nsk/jdwp tests to use driver instead of othervm [v4]

Chris Plummer cjplummer at openjdk.org
Tue Jun 11 20:33:15 UTC 2024


On Tue, 11 Jun 2024 18:48:41 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The jdwp tests use debugger and debugee. There is no goal to execute debugger part with all VM flags, they are needed to be used with debugee VM only.
>> The change is all tests is to don't use System.exit() and use 'driver' instead of othervm.
>> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeBinder.java
>> is updated to correctly set classpath for debugee
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8330534
>  - reverted jdi
>  - jdi cleanup.
>  - identation updated.
>  - 8330534: Update nsk/jdwp tests to use driver instead of othervm

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18826#pullrequestreview-2111403784


More information about the serviceability-dev mailing list