RFR: 8330846: Add stacks of mounted virtual threads to the HotSpot thread dump [v17]
Alan Bateman
alanb at openjdk.org
Wed Jun 12 08:37:18 UTC 2024
On Wed, 12 Jun 2024 07:14:59 GMT, Inigo Mediavilla Saiz <duke at openjdk.org> wrote:
>> Print the stack traces of mounted virtual threads when calling `jcmd <pid> Thread.print`.
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix scope of the try block
Thanks for taking feedback, I don't have any other comments.
test/hotspot/jtreg/serviceability/dcmd/thread/PrintMountedVirtualThread.java line 38:
> 36: * @requires vm.continuations
> 37: * @library /test/lib
> 38: * @modules java.base
The `@modules` line isn't needed, it's not possible to have a run-time image without java.base.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19482#pullrequestreview-2112334068
PR Review Comment: https://git.openjdk.org/jdk/pull/19482#discussion_r1636049421
More information about the serviceability-dev
mailing list