RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v3]

Kevin Walls kevinw at openjdk.org
Wed Jun 12 11:52:22 UTC 2024


On Tue, 11 Jun 2024 16:59:31 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Sean comments
>
> src/java.management/share/classes/javax/management/monitor/Monitor.java line 1541:
> 
>> 1539:             if (ac == null) {
>> 1540:                 // No SecurityManager:
>> 1541:                 Subject.doAs(s, action);
> 
> What if `s` is null?

Subject.doAs accepts a null Subject, so that's OK?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1636324060


More information about the serviceability-dev mailing list