RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v10]

Kevin Walls kevinw at openjdk.org
Fri Jun 14 13:14:20 UTC 2024


On Fri, 14 Jun 2024 12:44:17 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> src/java.management/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java line 353:
>> 
>>> 351:         } else {
>>> 352:             return Subject.getSubject(AccessController.getContext());
>>> 353:         }
>> 
>> `Subject.current()` should work for both cases. See the impl of it.
>
> It will work to get the Subject yes.
> Do I not need the SM-enabled case, in case there some complex ACC in place? (combiner)

OK if it was actually getting specifically the ACC to use it maybe, but this just needs to resolve a Subject.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19624#discussion_r1639806380


More information about the serviceability-dev mailing list