RFR: 8333117: Remove support of remote and manual debuggee launchers [v3]

Leonid Mesnik lmesnik at openjdk.org
Fri Jun 14 23:37:48 UTC 2024


On Fri, 14 Jun 2024 22:38:33 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed empty lines
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jdb/Launcher.java line 124:
> 
>> 122:         } else if (argumentHandler.isListeningConnector()) {
>> 123: 
>> 124:             localLaunchAndListen(jdbCmdArgs, classToExecute);
> 
> I'd suggest getting rid of all the empty lines. Not sure why they were there in the first place.

done

> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeArgumentHandler.java line 699:
> 
>> 697:                 || option.equals("debugee.host")
>> 698:                 || option.equals("test.host")) {
>> 699:             throw new RuntimeException("debugee.host option is not supported.");
> 
> Suggestion:
> 
>             throw new RuntimeException(""" + option + "" option is not supported.");

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19729#discussion_r1640457700
PR Review Comment: https://git.openjdk.org/jdk/pull/19729#discussion_r1640457884


More information about the serviceability-dev mailing list