RFR: 8332252: Clean up vmTestbase/vm/share [v2]
Chris Plummer
cjplummer at openjdk.org
Sat Jun 15 00:04:13 UTC 2024
On Fri, 14 Jun 2024 20:18:10 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The vmTestbase/vm/share is a shared test library for vmTestbase tests. This library contains a lot of code that is used by only by small number of tests or not used at all. There are no plans to actively develop new tests in vmTestsbase and improve this shared library.
>> The final goal of this and the following PRs is to reduce the maintenance cost of vmTestbase by eliminating this library.
>>
>> Also, this PR moves test-specific code into corresponding test directories to increase code locality. This allows later easier move tests from vmTestbase.
>>
>> The few remaining classes include
>> InMemoryJavaCompiler.java
>> that is very similar to same class from the standard testlibrary and could be merge with it and
>> ProcessUtils.java
>> which is used by
>> test/hotspot/jtreg/runtime/Thread/TestBreakSignalThreadDump.java
>> and thus should be moved into the standard testlibrary.
>> The stack and options might be merged in nsk/share test library.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> removed toHandle()
Marked as reviewed by cjplummer (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/19727#pullrequestreview-2119605926
More information about the serviceability-dev
mailing list