RFR: 8334164: The fix for JDK-8322811 should use _filename.is_set() rather than strcmp()
David Holmes
dholmes at openjdk.org
Mon Jun 17 05:01:15 UTC 2024
On Thu, 13 Jun 2024 16:55:15 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:
> Hi all,
>
> This PR addresses [8334164](https://bugs.openjdk.org/browse/JDK-8334164).
>
> Testing:
> - [x] Verified specifying the literal `vm_memory_map_<pid>.txt` as the map name does not replace `<pid>`.
> - [x] Verified `<pid>` is still appropriately replaced if a file path is not specified.
>
> Thanks,
> Sonia
Seems fine. Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19706#pullrequestreview-2121860936
More information about the serviceability-dev
mailing list