RFR: 8334215: serviceability/dcmd/thread/PrintMountedVirtualThread.java failing with JTREG_TEST_THREAD_FACTORY=Virtual [v4]

[David Holmes]

On Tue, 18 Jun 2024 11:51:31 GMT, Inigo Mediavilla Saiz <duke at openjdk.org> wrote:

>> Follow up to https://github.com/openjdk/jdk/pull/19482 that was causing issues when the PrintMountedVirtualTest.java was
>> running with `JTREG_TEST_THREAD_FACTORY=Virtual` in the loom repo. 
>> 
>> - Fixes issues where the test observes the thread during transitions.
>> - Fixes a potential issue in the test where CountDownLatch.countDown unparks the main (virtual) thread and the main thread observes the dummy thread is transition .
>
> Inigo Mediavilla Saiz has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove thread name from the output

Okay. I still have some general concerns about the underlying implementation issues, but as long as the test will now pass reliably that is okay.

FWIW I would have kept the vt name just in case it does have one. But as Alan said that can be added in later if desired.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19744#pullrequestreview-2127148088