RFR: 8333344: JMX attaching of Subject does not work when security manager not allowed [v19]
Daniel Fuchs
dfuchs at openjdk.org
Wed Jun 19 11:24:16 UTC 2024
On Tue, 18 Jun 2024 12:17:46 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> JMX uses APIs related to the Security Mananger which are deprecated. Use of AccessControlContext will be removed when Security Manager is removed.
>>
>> Until then, updates are needed to not require setting -Djava.security.manager=allow to use JMX authentication.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> Additional test runs with SM enabled
The code changes look good to me (if a bit verbose) and the test changes look reasonable. It could be beneficial to add some more tests in the future involving monitoring and getting the subject from within a monitored MBean.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19624#pullrequestreview-2127943873
More information about the serviceability-dev
mailing list