RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container [v2]

Severin Gehwolf sgehwolf at openjdk.org
Thu Jun 20 12:06:48 UTC 2024


On Tue, 16 Apr 2024 18:25:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8261242-is-containerized-fix
>>  - jcheck fixes
>>  - Fix tests
>>  - Implement Metrics.isContainerized()
>>  - Some clean-up
>>  - Drop cgroups testing on plain Linux
>>  - Implement fall-back logic for non-ro controller mounts
>>  - Make find_ro static and local to compilation unit
>>  - 8261242: [Linux] OSContainer::is_containerized() returns true
>
> I am not enough of a container expert to judge if the basic approach is right - I trust you on this. This is just a technical code review.

@tstuefe Do you mind to take another look? Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18201#issuecomment-2180504024


More information about the serviceability-dev mailing list