RFR: 8318026: jcmd should provide access to low-level JVM debug information [v4]

Kevin Walls kevinw at openjdk.org
Mon Mar 4 15:10:12 UTC 2024


On Tue, 27 Feb 2024 01:30:27 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Usage correction
>>  - Help to clarify this is VM inspection.  Comment to relate source to debug.cpp.
>>  - jcheck trailing whitespace
>
> src/hotspot/share/services/diagnosticCommand.cpp line 1200:
> 
>> 1198: void VMDebugDCmd::find() {
>> 1199:   if (!_arg1.has_value()) {
>> 1200:     output()->print_cr("missing argument");
> 
> I'm thinking if it would be useful to tell what arguments are expected? This is for all cases where the `"missing argument"` message is returned.

Thanks Serguei, have filled in explicit usage instructions when the commands are missing an argument.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1511313428


More information about the serviceability-dev mailing list