RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v21]

Serguei Spitsyn sspitsyn at openjdk.org
Tue Mar 5 01:48:48 UTC 2024


On Mon, 4 Mar 2024 10:02:03 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1552:
>> 
>>> 1550:         // If the thread was found on the ObjectWaiter list, then
>>> 1551:         // it has not been notified. This thread can't change the
>>> 1552:         // state of the monitor so it doesn't need to be suspended.
>> 
>> Not sure why suspension is being mentioned here.
>
> This is the original comment. I also do not quite understand it. It is confusing for sure. I can remove it if Dan does not object.

Removed this statement from the comment. Will restore in a case of Dan's objection.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1512020517


More information about the serviceability-dev mailing list