RFR: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Mar 5 19:43:46 UTC 2024
On Tue, 5 Mar 2024 18:16:03 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review: addressed a couple of comments on new test
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/InterruptRawMonitor/InterruptRawMonitor.java line 51:
>
>> 49: System.out.println(thread);
>> 50: thread.start();
>> 51: Thread.sleep(2000);
>
> I think it would be better to check 'thread' status or the same monitor to sync instead of sleep. The sleep is always looks suspect, especially when intermittent failure happens.
> Also, it helps to save 2 seconds.
Will implement this suggestion, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18093#discussion_r1513397834
More information about the serviceability-dev
mailing list