RFR: 8325532: serviceability/dcmd/compiler/PerfMapTest.java leaves created files in the /tmp dir.

[Chris Plummer]

On Tue, 5 Mar 2024 01:48:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Hi Jai. I think that solves all the functional requirements, but now we've turned two easily understood lines of code (calling run() and deleteIfExists()) into what you have above. I'm not so sure it is worth it. I refer back to Leonid's comment above on this topic:
>> 
>>> I thought about execution of Files.deleteIfExists(path) in the case of test fails, but decided that it is not so important. Also, test always might fail with crash when no finally block is executed. So I am fine with current way.
>
> Hello Chris,
>> Hi Jai. I think that solves all the functional requirements, but now we've turned two easily understood lines of code (calling run() and deleteIfExists()) into what you have above. 
> 
> I agree. 
> 
>> I'm not so sure it is worth it. I refer back to Leonid's comment above on this topic:
>> 
>> > I thought about execution of Files.deleteIfExists(path) in the case of test fails, but decided that it is not so important. Also, test always might fail with crash when no finally block is executed. So I am fine with current way.
> 
> What Leonid suggests looks fine to me and keeps things simple.

Ok. I think then I'll just push this PR in its current form.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17992#discussion_r1513556350