RFR: 8325187: JVMTI GetThreadState says virtual thread is JVMTI_THREAD_STATE_INTERRUPTED when it no longer is [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Mar 6 09:06:46 UTC 2024
On Wed, 6 Mar 2024 06:28:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> Please, review this fix correcting the JVMTI `RawMonitorWait()` implementation.
>> The `RawMonitorWait()` is using the the `jt->is_interrupted(true)` to update the interrupt status of the interrupted waiting thread. The issue is that when it calls `jt->is_interrupted(true)` to fetch and clear the `interrupt status` of the virtual thread, this information is not propagated to the `java.lang.Thread` instance.
>> In the `VirtualThread` class implementation the `interrupt status` for virtual thread is stored for both virtual and carrier threads. It is because the implementation of object monitors for virtual threads is based on pinning virtual threads, and so, always operates on carrier thread. The fix is to clear the interrupt status for both virtual and carrier `java.lang.Thread` instances.
>>
>> Testing:
>> - tested with new test `hotspot/jtreg/serviceability/jvmti/vthread/InterruptRawMonitor` which is passed with the fix and failed without it
>> - ran mach5 tiers 1-6
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: improved sync in new test InterruptRawMonitor
Added `ObjectLocker` of the `interruptLock` for sync to the `JavaThread::is_interrupted()`.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18093#issuecomment-1980391743
More information about the serviceability-dev
mailing list