RFR: JDK-8327444: simplify RESTARTABLE macro usage in JDK codebase
Matthias Baesken
mbaesken at openjdk.org
Wed Mar 6 14:27:48 UTC 2024
On Wed, 6 Mar 2024 14:13:26 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> We define the RESTARTABLE macro again and again at a lot of places in the JDK native codebase. This could be centralized to avoid repeating it again and again !
>
> src/java.base/share/native/libjava/jni_util.h line 243:
>
>> 241: } while((_result == -1) && (errno == EINTR)); \
>> 242: } while(0)
>> 243:
>
> jni_util.h is for all platforms so not the right place for a Unix specific macro. We need think where the right place for this, might have to introduce a jni_util_md.h.
We could maybe also use the existing https://github.com/openjdk/jdk/blob/master/src/java.base/unix/native/include/jni_md.h - what do you think ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18132#discussion_r1514574059
More information about the serviceability-dev
mailing list