RFR: 8308745: ObjArrayKlass::allocate_objArray_klass may call into java while holding a lock [v2]

[David Holmes]

On Thu, 7 Mar 2024 01:38:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change creates a new sort of native recursive lock that can be held during JNI and Java calls, which can be used for synchronization while creating objArrayKlasses at runtime.
>> 
>> Passes tier1-7.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Dean's comments.

src/hotspot/share/oops/instanceKlass.cpp line 1552:

> 1550:     RecursiveLocker rl(MultiArray_lock, THREAD);
> 1551: 
> 1552:     // This thread is the creator.

This thread may not be the creator. The original comment was more apt - we typically say something like "Check if another thread beat us to it."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17739#discussion_r1515371571