RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v23]

[Serguei Spitsyn]

On Mon, 11 Mar 2024 18:08:01 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 26 commits:
>> 
>>  - Merge
>>  - review: minor tweak in test description of ObjectMonitorUsage.java
>>  - review: addressed more comments on the fix and new test
>>  - rename after merge: jvmti_common.h to jvmti_common.hpp
>>  - Merge
>>  - review: update comment in threads.hpp
>>  - fix deadlock with carrier threads starvation in ObjectMonitorUsage test
>>  - resolve merge conflict for deleted file objmonusage003.cpp
>>  - fix a typo in libObjectMonitorUsage.cpp
>>  - fix potential sync gap in the test ObjectMonitorUsage
>>  - ... and 16 more: https://git.openjdk.org/jdk/compare/de428daf...b97b8205
>
> src/hotspot/share/runtime/threads.cpp line 1186:
> 
>> 1184: 
>> 1185: #if INCLUDE_JVMTI
>> 1186: // Get count Java threads that are waiting to enter or re-enter the specified monitor.
> 
> nit typo: s/count Java/count of Java/

Thanks, fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1520714780