RFR: 8309271: A way to align already compiled methods with compiler directives [v29]

Dmitry Chuyko dchuyko at openjdk.org
Wed Mar 13 17:34:24 UTC 2024


On Wed, 13 Mar 2024 07:48:35 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Dmitry Chuyko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 47 commits:
>> 
>>  - Resolved master conflicts
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - Merge branch 'openjdk:master' into compiler-directives-force-update
>>  - ... and 37 more: https://git.openjdk.org/jdk/compare/782206bc...ff39ac12
>
> src/hotspot/share/services/diagnosticCommand.cpp line 928:
> 
>> 926:                            DCmdWithParser(output, heap),
>> 927:   _filename("filename", "Name of the directives file", "STRING", true),
>> 928:   _refresh("-r", "Refresh affected methods.", "BOOLEAN", false, "false") {
> 
> Nit: The dot is not needed at the end, I think. The same applies to lines: 945, 970 and 987.

Thanks, the dots were removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14111#discussion_r1523664980


More information about the serviceability-dev mailing list