RFR: 8328285: GetOwnedMonitorInfo functions should use JvmtiHandshake

David Holmes dholmes at openjdk.org
Mon Mar 18 04:47:26 UTC 2024


On Fri, 15 Mar 2024 20:14:22 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The `JvmtiHandshake` and `JvmtiUnitedHandshakeClosure` classes were introduced in the JDK 22 to unify/simplify the JVM TI functions supporting implementation of the virtual threads. This enhancement is to refactor JVM TI functions `GetOwnedMonitorInfo` and `GetOwnedMonitorStackDepthInfo` on the base of `JvmtiHandshake and `JvmtiUnitedHandshakeClosure` classes.
> 
> Testing:
>  - Ran mach5 tiers 1-6

src/hotspot/share/prims/jvmtiEnvBase.cpp line 2004:

> 2002: 
> 2003:   hs_cl->set_target_jt(target_jt);   // can be needed in the virtual thread case
> 2004:   hs_cl->set_is_virtual(is_virtual); // needed when suspend is required for non-current target thread

Is this comment correct? Seems like it was just copied.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18332#discussion_r1527812762


More information about the serviceability-dev mailing list