RFR: 8327704: Update nsk/jdi tests to use driver instead of othervm [v3]

Leonid Mesnik lmesnik at openjdk.org
Tue Mar 19 22:06:20 UTC 2024


On Sat, 9 Mar 2024 05:27:43 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> vmtestbase nsk/jdi tests run 2 processes: debugger and debugee.
>> There is not need to start  debugger in the separate process for each test. Also, no need to run it with "-Xcomp" because the main goal is to test debugee behavior with different VM flags.
>> This fix updates tests to run debugger as driver to optimize execution time.
>> The fix also eliminates System.exit() which is not compatible with driver/agentvm mode and update shared classes to correctly add classpath when running debugee.
>> There were few tests which still execute using othervm mode. They require some specific classpath/settings. 
>> Tested by running all tests, with '-Xcomp' and virtual thread test factory.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reverted failing tests.

They also updated just to throw RuntimeException as other tests.

On Tue, Mar 19, 2024 at 2:20 PM Chris Plummer ***@***.***>
wrote:

> So no changes were made to any of these tests?
>
>> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/18174#issuecomment-2008154319>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABOQDW4KAIFB5Q5BLKAROS3YZCTYFAVCNFSM6AAAAABENMXMB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGE2TIMZRHE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18174#issuecomment-2008214565


More information about the serviceability-dev mailing list