RFR: 8327990: [macosx-aarch64] Various tests fail with -XX:+AssertWXAtThreadSync [v4]
Martin Doerr
mdoerr at openjdk.org
Wed Mar 20 14:06:04 UTC 2024
On Wed, 20 Mar 2024 14:02:23 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> This pr changes `JfrJvmtiAgent::retransform_classes()` and `jfr_set_enabled` to switch to `WXWrite` before transitioning to the vm.
>>
>> Testing:
>> make test TEST=jdk/jfr/event/runtime/TestClassLoadEvent.java TEST_VM_OPTS=-XX:+AssertWXAtThreadSync
>> make test TEST=compiler/intrinsics/klass/CastNullCheckDroppingsTest.java TEST_VM_OPTS=-XX:+AssertWXAtThreadSync
>>
>> More tests are pending.
>
> Richard Reingruber has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into 8327990_jfr_enters_vm_without_wxwrite
> - 2 more locations
> - Merge branch 'master' into 8327990_jfr_enters_vm_without_wxwrite
> - Set WXWrite at more locations
> - Switch to WXWrite before entering the vm
Good catch!
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18238#pullrequestreview-1948978584
More information about the serviceability-dev
mailing list