RFR: 8328592: hprof tests fail with -XX:-CompactStrings [v2]

Alex Menkov amenkov at openjdk.org
Thu Mar 21 01:03:20 UTC 2024


On Wed, 20 Mar 2024 17:19:34 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug for symptoms. The tests are failing because hprof test library is confused about non-compact strings.
>> 
>> Additional testing:
>>  - [x] `serviceability/HeapDump lib-test:all` with `-XX:-CompactStrings` now pass
>>  - [x]  `serviceability/HeapDump lib-test:all` with `-XX:+CompactStrings` still pass
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Handle platform endianness better
>  - Merge branch 'master' into JDK-8328592-hprof-compact-strings
>  - Fix

Looks good. Please update copyright years before push

-------------

Marked as reviewed by amenkov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18394#pullrequestreview-1950543888


More information about the serviceability-dev mailing list