RFR: JDK-8328303: 3 JDI tests timed out with UT enabled [v2]

Alex Menkov amenkov at openjdk.org
Fri Mar 22 21:31:27 UTC 2024


On Fri, 22 Mar 2024 20:45:51 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassPrepareEvent/referenceType/refType001.java line 116:
>> 
>>> 114: 
>>> 115:                     boolean isConnected = true;
>>> 116:                     boolean eventsReceived = false;
>> 
>> Nit: It'd better to rename this local to `allEventsReceived`.
>
> I tried to make minimal changes in the tests, so kept variable names to avoid unnecessary changes

Looks like all lines with the variable are already touched, I'll change the name

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18442#discussion_r1536212976


More information about the serviceability-dev mailing list