RFR: 8318026: jcmd should provide access to detailed JVM object information [v8]

[Kevin Walls]

On Tue, 26 Mar 2024 20:52:30 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 20 additional commits since the last revision:
>> 
>>  - Change to jcmd VM.inspect
>>  - Merge remote-tracking branch 'upstream/master' into 8318026_jcmd_VMdebug_command
>>  - Test update
>>  - Show description if unknown subcommand.
>>  - Remove unnecessary 'events' subcommand.
>>  - Usage correction
>>  - Help to clarify this is VM inspection.  Comment to relate source to debug.cpp.
>>  - jcheck trailing whitespace
>>  - Test update omitted from previous commit.
>>  - Merge remote-tracking branch 'upstream/master' into 8318026_jcmd_VMdebug_command
>>  - ... and 10 more: https://git.openjdk.org/jdk/compare/91a3bbb4...739bcbfa
>
> src/hotspot/share/services/diagnosticCommand.cpp line 59:
> 
>> 57: #include "runtime/jniHandles.hpp"
>> 58: #include "runtime/os.hpp"
>> 59: #include "runtime/threads.hpp"
> 
> Is the `#include` lines a leftover from the initial version? Do we still need them?

Yes, undoing that, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1540153524