RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v4]

[Daniel D. Daugherty]

On Wed, 27 Mar 2024 20:08:19 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: improve diagnostics and reliability
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp line 163:
> 
>> 161:     LOG("Main: ensureAtBreakpoint: waitig 5 millis\n");
>> 162:     if (++attempts > 100) {
>> 163:       fatal(jni, "Main: ensureAtBreakpoint: waited 1 sec");
> 
> 1 second isn't very long when you are talking about something that is relying on debugger/debuggee communication. Maybe wait 100ms at a time for a total of 10 seconds.

Caught this comment in passing. Delays like this should be scaled with
defaultTimeoutFactor so that test tasks that invoke tests with options
that can slow the test down, e.g., `-Xcomp`, can be accommodated.

I believe the defaultTimeoutFact for `-Xcomp` test tasks gets bumped
from 4 to 10.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1541986223