RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v4]

[Chris Plummer]

On Wed, 27 Mar 2024 19:59:28 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: improve diagnostics and reliability
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp line 161:
> 
>> 159:   int attempts = 0;
>> 160:   while (!bp_sync_reached) {
>> 161:     LOG("Main: ensureAtBreakpoint: waitig 5 millis\n");
> 
> Suggestion:
> 
>     LOG("Main: ensureAtBreakpoint: waiting 10 millis\n");
> 
> 
> I think this should be moved directly above the wait(10) call.

I think you missed this suggestion. There is a typo in the log message, and this LOG should be move to just before the wait() statement below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544028878