RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v4]

[Daniel D. Daugherty]

On Thu, 28 Mar 2024 23:29:53 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Caught this comment in passing. Delays like this should be scaled with
>> defaultTimeoutFactor so that test tasks that invoke tests with options
>> that can slow the test down, e.g., `-Xcomp`, can be accommodated.
>> 
>> I believe the defaultTimeoutFact for `-Xcomp` test tasks gets bumped
>> from 4 to 10.
>
> Thanks for the comments, Chris and Dan. Updated as Chris suggested. I've added this with `-Xcomp` consideration as the worst case scenario in mind. Now, I think it is more save to make it 10 seconds instead of one. Is it going to be good enough? In fact, I've added this for manual testing to save time in waiting for test completion when it is deadlocked. Also, this is better for diagnosability.

runtime/8176717/TestInheritFD.java has an example of what I'm talking about:

    public static float timeoutFactor = Float.parseFloat(System.getProperty("test.timeout.factor", "1.0"));
    public static long subProcessTimeout = (long)(15L * timeoutFactor);

so you fetch the test.timeout.factor value and then you scale your delay value.

Also:

nit typo: s/waitig/waiting/

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544497738