RFR: 8328083: degrade virtual thread support for GetObjectMonitorUsage [v2]

Chris Plummer cjplummer at openjdk.org
Thu May 2 21:52:55 UTC 2024


On Thu, 2 May 2024 21:36:27 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Thank you for the comment. In fact, I don't know how to fix it.
>> Replacing of NUMBER_OF_ENTERING_THREADS/NUMBER_OF_WAITING_THREADS in comments with `expEnteringCount/expWaitingCount` does not make sense to me. The comments are about the tested pattern, not about the real values. Please, let me know if you have any suggestion on fixing.
>
> expEnteringCount/expWaitingCount contain the tested patterns. I don't see why they can't just replace NUMBER_OF_ENTERING_THREADS/NUMBER_OF_WAITING_THREADS in the comments also. In fact it is confusing if you don't because code right below the comments references expEnteringCount/expWaitingCount, not NUMBER_OF_ENTERING_THREADS/NUMBER_OF_WAITING_THREADS.

...and there are also comments above with this issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19030#discussion_r1588456637


More information about the serviceability-dev mailing list