RFR: 8330534: Update nsk/jdwp tests to use driver instead of othervm
Serguei Spitsyn
sspitsyn at openjdk.org
Sat May 4 10:09:51 UTC 2024
On Wed, 17 Apr 2024 20:19:49 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> The jdwp tests use debugger and debugee. There is no goal to execute debugger part with all VM flags, they are needed to be used with debugee VM only.
> The change is all tests is to don't use System.exit() and use 'driver' instead of othervm.
> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/DebugeeBinder.java
> is updated to correctly set classpath for debugee
This looks okay in general.
There is a missing space in half of files in method `run()` parameters noticed by Andrei.
Also, Chris had some concerns about converting to the `driver` mode.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18826#pullrequestreview-2039316239
More information about the serviceability-dev
mailing list