Integrated: 8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
Aleksey Shipilev
shade at openjdk.org
Mon May 6 11:21:57 UTC 2024
On Thu, 2 May 2024 14:40:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> `CollectedHeap::is_gc_active()` is confusing, since its name implies _any_ GC phase is running, while it actually only covers the STW GCs. It would be good to rename it for clarity. The freed-up name, `is_gc_active` could then be repurposed to track any (concurrent or STW) GC phase running. That would be useful to resolve [JDK-8331572](https://bugs.openjdk.org/browse/JDK-8331572).
>
> Doing this rename separately guarantees we have caught and renamed all current uses.
>
> Additional testing:
> - [x] Linux AArch64 server fastdebug, `all`
This pull request has now been integrated.
Changeset: 1eec30a6
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/1eec30a6c03b7f4028405dc9bdb4d2a663b3987d
Stats: 64 lines in 27 files changed: 0 ins; 2 del; 62 mod
8331573: Rename CollectedHeap::is_gc_active to be explicitly about STW GCs
Reviewed-by: stefank, zgu, tschatzl, gli
-------------
PR: https://git.openjdk.org/jdk/pull/19064
More information about the serviceability-dev
mailing list