RFR: 8329418: Replace pointers to tables with offsets in relocation bitmap

[Matias Saavedra Silva]

On Mon, 6 May 2024 22:32:12 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The beginning of the RW region contains pointers to c++ vtables which are always located at a fixed offset from the shared base address at runtime. This offset can be calculated at dumptime and stored with the read-only tables at the top of the RO region. As a further improvement, all the pointers to RO tables are replaced with offsets as well.
>> 
>> These changes will reduce the number of pointers in the RW and RO regions and will allow for the relocation bitmap size optimizations to be more effective. Verified with tier 1-5 tests.
>
> test/hotspot/jtreg/serviceability/sa/TestSysProps.java line 68:
> 
>> 66:         }
>> 67:         if (numProps != expectedCount) {
>> 68:             throw new RuntimeException("Wrong number of " + cmdName + " properties: " + numProps + " Expected: " + expectedCount);
> 
> I think it would be good to add parenthesis around the extra output you added.

This was an accidental leftover from debugging, I didn't intend for this to be part of the change. I should revert this since it's beyond the scope of this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19107#discussion_r1592648930